refactor: clarify auth monorepo as php/ + ui/ packages#13
Merged
Conversation
auth ships two independently-published packages; the layout obscured this. - Rename laravel/ -> php/ (source for the bherila/auth-laravel Composer package). The published manifest stays at the repo root (required for Composer VCS resolution by downstream apps); only the internal source path moves. - Delete the duplicate nested laravel/composer.json + composer.lock, which re-declared the same package and was unreferenced. Root composer.json is now the single PHP manifest. - Repoint root composer.json PSR-4 (php/src, php/tests) and phpunit.xml; update .gitignore (php/vendor/) and README references. - Replace the single-job test.yml with a two-job, path-filtered ci.yml: a PHP job (composer test) and a JS job (bwh-auth typecheck + build). No app-style Laravel-env/build steps, which never applied to this package repo. Verified locally: PHPUnit 33/33 green on php/, bwh-auth typecheck + build green. No change to package identities, so downstream consumers need no edits. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pnpm/action-setup@v6 requires a version when no root packageManager field exists (auth has none at repo root). Pins version: 10. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bherila
force-pushed
the
refactor/auth-monorepo-layout
branch
from
6300e86 to
8d76e69
Compare
Match the local dev runtime (8.5.x) and the team standard of validating on 8.5. 8.5 satisfies the package's composer ^8.2 constraint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
@codex review this PR exhaustively |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
authships two independently-published packages, but the old layout obscured that and a CI proposal had tried to treat the repo as a single Laravel app:bherila/auth-laravel(type: library), consumed by 5 downstream apps via a Composer VCS repository at the repo root.bwh-auth(React/WebAuthn), consumed via a GitHub release tarball.There was also a duplicate
laravel/composer.json(+ lockfile) re-declaring the same package, which nothing referenced.Changes
laravel/→php/for the PHP package source. The published manifest stays at the repo root (Composer VCS resolution requires it there), so package identity is unchanged.laravel/composer.json+composer.lock. Rootcomposer.jsonis now the single PHP manifest.composer.jsonPSR-4 (php/src,php/tests) +phpunit.xml; update.gitignore(php/vendor/) and README references.test.ymlwith a two-job, path-filteredci.yml: a PHP job (composer test) and a JS job (bwh-authtypecheck + build), withconcurrencycancel on non-main. No Laravel-app env/build steps (which never applied here).Consumer impact
None required. Package name, VCS URL, and
^0.4constraint are unchanged — downstream apps pick up the next tag on a normalcomposer update.ui/did not move, so thebwh-authtarball is unaffected.Verification (local)
composer install && composer test→ PHPUnit 33/33 green onphp/.pnpm install --frozen-lockfile+pnpm --filter bwh-auth run typecheck+build→ green.AuthServiceProviderloads config/routes/views/migrations via__DIR__relatives — unaffected by the move.🤖 Generated with Claude Code